feat!(ranking): Add new methods for the different ranking modes on GetRanking #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tRanking There's 5 different types of GetRanking call, asking for: - global leaderboards - global leaderboards, nearby to your own rank - only your friends - only your friends, nearby to your own rank - your own ranking only These are pretty fundamentally different requests that would need different db queries, etc. at the implementation level. Notably all but the first need knowledge of the PID of the user making the request (to get their rank and their friends). Add new methods to the protocol for each of these use cases.
|
We define the relevant constants for protocols inside nex-protocols-go. See this example: https://github.com/PretendoNetwork/nex-protocols-go/blob/master/nintendo-notifications/notification_types.go We could also replace that big |
4 tasks
ItzSwirlz
reviewed
Jul 24, 2024
| var rankDataList *types.List[*ranking_types.RankingRankData] | ||
| var totalCount uint32 | ||
|
|
||
| if rankingMode.Value == 0 { |
There was a problem hiding this comment.
Suggested change
| if rankingMode.Value == 0 { | |
| switch rankingMode.Value { | |
| case 0: | |
| rankDataList, totalCount, err = commonProtocol.GetRankingsAndCountByCategoryAndRankingOrderParam(category, orderParam) | |
| case 1: | |
| rankDataList, totalCount, err = commonProtocol.GetNearbyRankingsAndCountByCategoryAndRankingOrderParam(callerPid, category, orderParam) | |
| case 2: | |
| rankDataList, totalCount, err = commonProtocol.GetFriendsRankingsAndCountByCategoryAndRankingOrderParam(callerPid, category, orderParam) | |
| case 3: | |
| rankDataList, totalCount, err = commonProtocol.GetNearbyFriendsRankingsAndCountByCategoryAndRankingOrderParam(callerPid, category, orderParam) | |
| default: // rankingMode.Value == 4 | |
| rankDataList, totalCount, err = commonProtocol.GetOwnRankingByCategoryAndRankingOrderParam(callerPid, category, orderParam) | |
| } |
man I still cant figure out suggestions with GitHub for multiple lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's 5 different types of GetRanking call, asking for:
These are pretty fundamentally different requests that would need different db queries, etc. at the implementation level. Notably all but the first need knowledge of the PID of the user making the request (to get their rank and their friends).
Changes:
Add new methods to the protocol for each of these use cases.
Submitting as a draft because I know
if rankingMode.Value == 0 {is the wrong way to do it, but I couldn't find any other protocol with constants like that for me to reference against. If someone count point out where I should define constants for this sort of thing I'll happily clean up the magic numbers.There's a highly WIP implementation of this API here: https://github.com/ashquarky/puyo-wiiu/blob/ranking/datastore/puyo_ranking.go
Note the dramatically different database requests needed for each mode.